Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle empty domain segments correctly in idna #256
Closed
Conversation
Spec asks us to "Otherwise join the labels using U+002E FULL STOP as a
separator". The current code checking if the result was non-empty would
fail if the segments themself were non-empty. It should be equivalent to
`.split('.').map(.. processing ..).join('.')`. Implementing it
procedurally since the code is already pretty procedural.
|
Closing in favor of #171, I’ll comment there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedDec 18, 2016
•
edited by larsbergstrom
Spec asks us to "Otherwise join the labels using U+002E FULL STOP as a separator". The current code checking if the result was non-empty would fail if the segments themself were non-empty. It should be equivalent to
.split('.').map(.. processing ..).join('.'). Implementing it procedurally since the code is already pretty procedural and it avoids extra allocations.Should
processing()return an iterator? We seem to be needlessly deconstructing and reconstructing the same string twice. OTOH that would mean more allocations.r? @SimonSapin
fixes #255
This change is