Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty domain segments correctly in idna #256

Closed
wants to merge 1 commit into from
Closed

Handle empty domain segments correctly in idna #256

wants to merge 1 commit into from

Commits on Dec 18, 2016

  1. Handle empty domain segments correctly in idna (fixes #255) 

    Spec asks us to "Otherwise join the labels using U+002E FULL STOP as a
separator". The current code checking if the result was non-empty would
fail if the segments themself were non-empty. It should be equivalent to
`.split('.').map(.. processing ..).join('.')`. Implementing it
procedurally since the code is already pretty procedural.
    @Manishearth
    Manishearth committed Dec 18, 2016
    Loading status checks…
    37ff338
You can’t perform that action at this time.