Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake mod host public #265
Closed
Make mod host public #265
Conversation
|
You can already call it. https://docs.rs/url/1.2.4/url/enum.Host.html#method.parse A module doesn't need to be public for public methods in it to be exposed outside, what matters is whether the type on which the method is is exposed or not. |
|
Oh, I hadn't noticed the enum is public. @nox thanks for pointing it out. Sorry for the noise. |
|
@valenting No problem. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
valenting commentedDec 30, 2016
•
edited by larsbergstrom
This just makes the mod public, so I can call into Host::parse() from rust_url_capi.
@Manishearth @SimonSapin
This change is