Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly compress sequences of 2 or more zero segments for IPV6 hosts #267
Conversation
|
Did the spec change? Are the test changes from upstream wpt? If not please also send a PR upstream. |
|
It's always been in the spec (whatwg/url@074fb08#diff-2502abf17adfd0b7f0904c0cbe40ddd7R543)
Yeah, I will soon, wanted to wait for review. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2017
Only compress sequences of 2 or more zero segments for IPV6 hosts (fixes #266) cc @valenting r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/267) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJan 2, 2017
•
edited by larsbergstrom
(fixes #266)
cc @valenting
r? @SimonSapin
This change is