Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix warnings. #269
Merged
Fix warnings. #269
Conversation
|
Looks like the import is used, but should be behind |
|
Indeed, Travis fails: error: no method named `description` found for type `parser::ParseError` in the current scope
--> src/lib.rs:1523:45
|
1523 | serde::Error::invalid_value(err.description())
| ^^^^^^^^^^^
|
= help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
= help: candidate #1: `use std::error::Error;` |
|
Fixed. |
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2017
Fix warnings. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/269) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedJan 3, 2017
•
edited by larsbergstrom
This change is