Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements to doc examples. #270

Merged
merged 5 commits into from Jan 4, 2017
Merged

More improvements to doc examples. #270

merged 5 commits into from Jan 4, 2017
+123 −0

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Jan 4, 2017 •
edited by larsbergstrom

This change is Reviewable
frewsxcv added 5 commits Jan 3, 2017
@frewsxcv
Add doc examples for `url::Url::from_file_path`.
1d3e0dc
@frewsxcv
Add doc examples for `url::Url::set_scheme`.
5dd6bf5
@frewsxcv
Add interesting case for `url::Url::domain` doc examples.
312495c
@frewsxcv
Add interesting case for `url::Url::set_port` doc examples.
752d216
@frewsxcv
Add doc examples for `url::Url::set_host`.
Loading status checks…
c4113d1
@Hoverbear
Hoverbear approved these changes Jan 4, 2017
View changes
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 4, 2017

@bors-servo r=Hoverbear
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

📌 Commit c4113d1 has been approved by Hoverbear
@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

⚡ Test exempted - status
@bors-servo bors-servo merged commit c4113d1 into servo:master Jan 4, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details
bors-servo added a commit that referenced this pull request Jan 4, 2017
@bors-servo
Auto merge of #270 - frewsxcv:doc-examples, r=Hoverbear
Loading status checks…
4e947f3 
More improvements to doc examples.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/270)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @Ms2ger @bors-servo @Hoverbear
You can’t perform that action at this time.