Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd Url::parse_with_params() #271
Conversation
|
Looks good! Just a few small things: please add |
|
Does it need to be 1.3.0? It's not a breaking change, only adds an API. |
|
Yes, exactly. A breaking change would be 2.0.0. |
|
Hurray for semver @SimonSapin changes made and commits squashed! |
|
I think @emilio means whether it can be |
|
@KiChjang @emilio. Hey all. Apologies if rust-url isn't following true semver, but if it is: "MINOR version when you add functionality in a backwards-compatible manner" - semver.org. Patch version is typically reserved for bug fixes. Happy to match the version to whatever you guys would like |
|
Yeah, 1.2.6 vs 1.3.0 is the same as far as Cargo is concerned. IMO we’d be just fine with just two components in the version number. But since semver is the convention in the rust ecosystem let’s do that. I was thinking of @bors-servo r+ |
|
|
|
|
add Url::parse_with_params() Allows us to build a `Url` from user-supplied params without the boilerplate of constructing then modifying the `Url`. This is in hopes of improving the ergenomics of the reqwest library: seanmonstar/reqwest#45 (comment) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/271) <!-- Reviewable:end -->
kybishop commentedJan 15, 2017
•
edited
Allows us to build a
Urlfrom user-supplied params without the boilerplate of constructing then modifying theUrl.This is in hopes of improving the ergenomics of the reqwest library: seanmonstar/reqwest#45 (comment)
This change is