Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive Eq and Hash for Serde<T> and add SerdeUrl type alias. #276
+6
−2
Conversation
|
Looks good, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 7, 2017
Derive Eq and Hash for Serde<T> and add SerdeUrl type alias. This should make Serde<Url> usable as an HashMap key, since that requires Eq and Hash to be implemented (and Url supports them). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/276) <!-- Reviewable:end -->
|
|
|
@SimonSapin would it be possible to push a new version of the crate to crates.io? |
|
Published v0.1.1. (Next time feel free to increment the version number in |
|
Thanks a lot @SimonSapin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lvillani commentedFeb 4, 2017
•
edited by larsbergstrom
This should make Serde usable as an HashMap key, since that requires Eq and Hash to be implemented (and Url supports them).
This change is