Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd fuzz scripts #281
Add fuzz scripts #281
Conversation
|
r=me with two changes. |
| path = "fuzzers/parse.rs" | ||
|
|
||
| [workspace] | ||
| members = ["."] |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 26, 2017
Member
Instead of creating a new workspace here, this crate should be added to the workspace at the root of this repository.
| @@ -0,0 +1,3 @@ | |||
|
|
|||
| target | |||
| libfuzzer | |||
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 26, 2017
Member
With the shared workspace (see other comment) there shouldn’t be a target directory here. As to libfuzzer, I’d prefer it to be fuzz/libfuzzer in .gitignore at the root of the repo.
|
Both those files are autogenerated by cargo-fuzz (the workspace=. is a generic solution so that the fuzz crate doesn't break when placed within a system that has an arbitrary workspace setup). It's better to not share target directories since we build with |
|
I think Cargo does rebuild when RUSTFLAGS changes, but ok. @bors-servo r+ |
|
|
Add fuzz scripts Add a simple script for fuzzing with https://github.com/rust-fuzz/cargo-fuzz Mostly autogenerated by cargo-fuzz; the contents of `go()` in parser.rs were manually written. cargo-fuzz is still WIP so the format here may change. This can be fuzzed (on Linux only) with `cargo fuzz --target parser` r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/281) <!-- Reviewable:end -->
|
|
Manishearth commentedFeb 21, 2017
•
edited by larsbergstrom
Add a simple script for fuzzing with https://github.com/rust-fuzz/cargo-fuzz
Mostly autogenerated by cargo-fuzz; the contents of
go()in parser.rs weremanually written.
cargo-fuzz is still WIP so the format here may change.
This can be fuzzed (on Linux only) with
cargo fuzz --target parserr? @SimonSapin
This change is