Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate serde dependency to 1.0 #297
Conversation
This changes updates serde dependency from 0.9 to 1.0 line. Only root sources update (no updates in sub-crates). Added lifetimes to Deserialize trait implementations. Use ownership instead of mutable reference and return results with associated types.
|
Thanks for you work, but I won’t be taking this pull request.
Because the disruption to the Rust ecosystem would be significant, I want to avoid making any breaking change to |
|
|
|
@SimonSapin Sending a PR is a best way to understand something )
|
|
The only reason for the separation is that adding support for serde 1.0 in
|
DenisKolodin commentedApr 30, 2017
•
edited
These changes updates
serdedependency from0.9to1.0line.Only root sources updated (no updates in sub-crates).
I added lifetimes to
Deserializetrait implementations and use ownership instead of mutable reference.Also I used associated types for results.
I see that there is #296, but that PR updates
url_serdeonly (that's why I haven't updated sub-crates).I've runned/passed all tests and checked it as dependency for my own project.
This change is