Skip to content

/rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html_root_url attribute #325

Merged
merged 1 commit into from May 9, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@DarkEld3r @SamWhited @SimonSapin @bors-servo
@DarkEld3r
Copy link
Contributor

DarkEld3r commented May 5, 2017 •
edited by larsbergstrom

Fixes #313

This change is Reviewable
@DarkEld3r
Add html_root_url attribute
Loading status checks…
4ceb629
@SamWhited

This comment has been minimized.

Sign in to view
Copy link
Contributor

SamWhited commented May 9, 2017

LGTM
@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Member

SimonSapin commented May 9, 2017

@bors-servo r+

Thanks!
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented May 9, 2017

📌 Commit 4ceb629 has been approved by SimonSapin
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented May 9, 2017

⌛️ Testing commit 4ceb629 with merge 780410c...

bors-servo added a commit that referenced this pull request May 9, 2017

@bors-servo
Auto merge of #325 - DarkEld3r:313-html-root-url-attribute, r=SimonSapin 
Add html_root_url attribute

Fixes #313

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/325)
<!-- Reviewable:end -->
Loading status checks…
780410c
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented May 9, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 780410c to master...

@bors-servo bors-servo merged commit 4ceb629 into servo:master May 9, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request May 9, 2017

Closed

Upgrade unicode-bidi to 0.3.0 #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.