Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples Url methods #326

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@ghost
Copy link

ghost commented May 6, 2017

Fix issue #309


This change is Reviewable

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented May 9, 2017

☔️ The latest upstream changes (presumably #331) made this pull request unmergeable. Please resolve the merge conflicts.

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented May 9, 2017

This includes a lot of unrelated changes in the same commit, making it difficult to find out what actually changed.

For example, using /*! … */ instead of //! for the crate’s doc-comment is deliberate: it make editing this very long comment much easier. Using two spaces before same-line comments is also a deliberate choice. Whitespace was added and removed at random places for no apparent reason.

@lucab

This comment has been minimized.

Copy link

lucab commented May 9, 2017

@SimonSapin from a quick glance at this, the large diff seems to be due to a rustfmt pass. Perhaps you may want to do a repo-wide pass separately so that further PR can start from a clean base?

@dtolnay

This comment has been minimized.

Copy link

dtolnay commented May 12, 2017

@hngnaig are you still working on rolling back those unrelated formatting changes?

@ghost

This comment has been minimized.

Copy link
Author

ghost commented May 12, 2017

@dtolnay sr for late, i still working on it, and commit rolling back those. :)

@lucab lucab referenced this pull request May 12, 2017

Open

Don’t rustfmt, yet #336

@ghost ghost closed this May 14, 2017

@ghost

This comment has been minimized.

Copy link
Author

ghost commented May 14, 2017

I open other PR to remove rustfmt

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.