Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd examples Url methods #326
Conversation
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
This includes a lot of unrelated changes in the same commit, making it difficult to find out what actually changed. For example, using |
This comment has been minimized.
This comment has been minimized.
lucab
commented
May 9, 2017
|
@SimonSapin from a quick glance at this, the large diff seems to be due to a rustfmt pass. Perhaps you may want to do a repo-wide pass separately so that further PR can start from a clean base? |
This comment has been minimized.
This comment has been minimized.
dtolnay
commented
May 12, 2017
|
@hngnaig are you still working on rolling back those unrelated formatting changes? |
This comment has been minimized.
This comment has been minimized.
|
@dtolnay sr for late, i still working on it, and commit rolling back those. :) |
ghost
closed this
May 14, 2017
This comment has been minimized.
This comment has been minimized.
|
I open other PR to remove rustfmt |
ghost commentedMay 6, 2017
•
edited by larsbergstrom
Fix issue #309
This change is