Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade unicode-bidi to 0.3.0 #329

Closed
wants to merge 1 commit into from
Closed

Upgrade unicode-bidi to 0.3.0 #329

wants to merge 1 commit into from

Conversation

@behnam
Copy link
Member

behnam commented May 9, 2017

Replace calls to deprecated API (bidi_class()) with the new function
name.

Depends on servo/unicode-bidi#27

r? @emilio @mbrubeck


This change is Reviewable

Replace calls to deprecated API (`bidi_class()`) with the new function
name.
@behnam
Copy link
Member Author

behnam commented May 9, 2017

@SimonSapin
Copy link
Member

SimonSapin commented May 9, 2017

Looks good to me, with the path dependency reverted to crates.io.

@behnam
Copy link
Member Author

behnam commented May 9, 2017

Thanks, @SimonSapin . Yeah, I'll fix up Cargo.toml after we have 0.3.0 out and update this diff to land.

@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

The latest upstream changes (presumably #325) made this pull request unmergeable. Please resolve the merge conflicts.

@behnam
Copy link
Member Author

behnam commented May 12, 2017

In some iterations, we landed on having the part of unicode-bidi API that's being used here unchanged into 0.3 version, so this diff is not necessary anymore.

@behnam behnam closed this May 12, 2017
@behnam behnam deleted the behnam:bidi-0.3 branch May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.