Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Modify examples to not call `unwrap` #345
Conversation
|
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. src/lib.rs, line 270 at r1 (raw file):
If you like to keep the function definition part of the example, then the content of the block should be indented. But, rustdoc has a nice way of letting you hide these execution details, using For example, this part would be:
More here: https://doc.rust-lang.org/book/documentation.html#documenting-macros Comments from Reviewable |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
Cool! I will fix this tomorrow, probably. Currently traveling for work meeting so might not have the time to get around to it. |
|
I believe you should also include a call to the |
|
I am looking at this again. Thanks for the pointer @mgeisler Will report soon. Sorry for the delay. |
|
|
|
This is done in #323. Thanks for the PR anyway! |
luisbg commentedMay 21, 2017
•
edited by larsbergstrom
This is for issue #312
Just fixing one case to check this is what the issue is about and that I understand the intended fix.
This change is