Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of fragment to documentation #357

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@tmccombs
Copy link
Contributor

tmccombs commented Jun 12, 2017

Fixes #318, fixes #332.

This builds on #332, and I hope addresses the comments there.


This change is Reviewable

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Jun 13, 2017

Looks good, thanks!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 13, 2017

📌 Commit abcb111 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 13, 2017

⌛️ Testing commit abcb111 with merge dc5cf2b...

bors-servo added a commit that referenced this pull request Jun 13, 2017

Auto merge of #357 - tmccombs:fragment, r=SimonSapin
Add description of fragment to documentation

Fixes #318, fixes #332.

This builds on #332, and I hope addresses the comments there.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/357)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 13, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing dc5cf2b to master...

@bors-servo bors-servo merged commit abcb111 into servo:master Jun 13, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.