Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded RESERVED_ENCODE_SET & STRICT_ENCODE_SET & more detailed docs. #358
Conversation
… delimeter characters, and STRICT_ENCODE_SET that encodes everything expect unreserved characters. Added more detailed descriptions to existings sets.
|
Resolves #353 |
golddranks
changed the title
|
|
|
I’m opposed to adding new encode sets just because they exist in some RFC. This is why the Closing in favor of #355 for the rest of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
golddranks commentedJun 12, 2017
•
edited by larsbergstrom
Added RESERVED_ENCODE_SET that corresponds to the set of reserved URL delimeter characters, and STRICT_ENCODE_SET that encodes everything expect unreserved characters. (As defined in the RFC 3986) Added more detailed descriptions to the existings sets.
This change is