Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: implement conversion to/from UNC paths #360

Merged
merged 5 commits into from Jun 13, 2017
Merged

Windows: implement conversion to/from UNC paths #360

merged 5 commits into from Jun 13, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 13, 2017 •
edited

This is a rebase of #284 with some additional fixes. Original work by @wfraser, sorry I took so long to get to this!

Fixes #284.

r? @nox for the last two commits.

This change is Reviewable
wfraser and others added 3 commits Feb 28, 2017
@wfraser @SimonSapin
Windows: implement conversion to/from UNC paths
60bb1f9
@wfraser @SimonSapin
re-structure to avoid #[cfg] on public functions
9bcf563 
also update the doc comment on `Url::to_file_path`.
@SimonSapin
Avoid re-parsing in Url::from_file_path
94d3605
SimonSapin added 2 commits Jun 13, 2017
@SimonSapin
Windows UNC paths: parse host and percent-encode share name
1ec057f
@SimonSapin
Increment version number for new feature (UNC paths).
Loading status checks…
d1ccb04
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 13, 2017

@bors-servo r=SimonSapin+nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2017

📌 Commit d1ccb04 has been approved by SimonSapin+nox
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2017

⌛ Testing commit d1ccb04 with merge 167fa4e...
bors-servo added a commit that referenced this pull request Jun 13, 2017
@bors-servo
Auto merge of #360 - servo:unc, r=SimonSapin+nox
Loading status checks…
167fa4e 
Windows: implement conversion to/from UNC paths

This is a rebase of #284 with some additional fixes. Original work by @wfraser, sorry I took so long to get to this!

Fixes #284.

r? @nox for the last two commits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/360)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 13, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin+nox
Pushing 167fa4e to master...
@bors-servo bors-servo merged commit d1ccb04 into master Jun 13, 2017
6 checks passed
6 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the unc branch Jun 13, 2017
@bors-servo bors-servo mentioned this pull request Jun 13, 2017
Merged
@SimonSapin SimonSapin mentioned this pull request Jun 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Windows: implement conversion to/from UNC paths
3 participants
@SimonSapin @bors-servo @wfraser
You can’t perform that action at this time.