Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeapSizeOf impl for ParseError #370

Merged
merged 2 commits into from Jun 25, 2017
Merged

Add HeapSizeOf impl for ParseError #370

merged 2 commits into from Jun 25, 2017

Conversation

@KiChjang
Copy link
Member

KiChjang commented Jun 25, 2017 •
edited by larsbergstrom

This change is Reviewable
@KiChjang KiChjang force-pushed the KiChjang:heapsizeof-parse-error branch from 74791c5 to 3d77bfb Jun 25, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Jun 25, 2017

  • Please use the known_heap_size! macro when possible
  • This does not compile. You need #[…] syntax to add an attribute to the next item, rather than #![…] which adds an attribute to the thing that contains such syntax.
@KiChjang KiChjang force-pushed the KiChjang:heapsizeof-parse-error branch from 3d77bfb to af16eef Jun 25, 2017
@KiChjang
Copy link
Member Author

KiChjang commented Jun 25, 2017

Ack, that was embarrassing. Fixed.
@KiChjang
Add HeapSizeOf impl for ParseError
ef40dcd
@KiChjang KiChjang force-pushed the KiChjang:heapsizeof-parse-error branch from af16eef to aea2ae2 Jun 25, 2017
@KiChjang
Version bump
Loading status checks…
aea2ae2
@SimonSapin
Copy link
Member

SimonSapin commented Jun 25, 2017

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2017

📌 Commit aea2ae2 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2017

⌛ Testing commit aea2ae2 with merge dd068e5...
bors-servo added a commit that referenced this pull request Jun 25, 2017
@bors-servo
Auto merge of #370 - KiChjang:heapsizeof-parse-error, r=SimonSapin
Loading status checks…
dd068e5 
Add HeapSizeOf impl for ParseError

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/370)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 25, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing dd068e5 to master...
@bors-servo bors-servo merged commit aea2ae2 into servo:master Jun 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:heapsizeof-parse-error branch Jun 25, 2017
@KiChjang
Copy link
Member Author

KiChjang commented Jun 25, 2017

Published this as 1.5.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@KiChjang @SimonSapin @bors-servo
You can’t perform that action at this time.