Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add licenses to sub-crates (Closes #376) #378

Merged
merged 1 commit into from Jul 5, 2017

Conversation

@ignatenkobrain
Copy link
Contributor

ignatenkobrain commented Jul 5, 2017

Signed-off-by: Igor Gnatenko ignatenko@redhat.com


This change is Reviewable

Igor Gnatenko
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
@ignatenkobrain ignatenkobrain changed the title add licenses to sub-crates add licenses to sub-crates (Closes #376) Jul 5, 2017
@SimonSapin
Copy link
Member

SimonSapin commented Jul 5, 2017

Are these symlinks? Have you checked that cargo package follows symlinks and includes the actual file in tarballs, rather than including symlinks as-is?

@ignatenkobrain
Copy link
Contributor Author

ignatenkobrain commented Jul 5, 2017

@SimonSapin it is following symlinks ;)

@SimonSapin
Copy link
Member

SimonSapin commented Jul 5, 2017

Alright, thanks.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2017

📌 Commit 3880b8e has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2017

Testing commit 3880b8e with merge 743c394...

bors-servo added a commit that referenced this pull request Jul 5, 2017
add licenses to sub-crates (Closes #376)

Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/378)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2017

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 743c394 to master...

@bors-servo bors-servo merged commit 3880b8e into servo:master Jul 5, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.