Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd more documentation for errors #382
Merged
Conversation
|
Looks good, thanks! @bors-servo r+
Pretty much the same, except saying "returns an error" or "returns |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2017
add more documentation for errors More documentations for errors. See #319 and #379 _Side question: I don't know how to document errors when a function returns `Result<(), ()>` so I did not document that part. I would be happy to see one example._ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/382) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rap2hpoutre commentedJul 17, 2017
•
edited
More documentations for errors. See #314 and #379
Side question: I don't know how to document errors when a function returns
Result<(), ()>so I did not document that part. I would be happy to see one example.This change is