Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThree-way merge with web-platform-tests #39
Closed
Conversation
| assert_eq!(port, expected_port); | ||
| match port { | ||
| None => assert_eq!(None, expected_port), | ||
| Some(port) => assert_eq!(Some(port.to_string()), expected_port) |
This comment has been minimized.
This comment has been minimized.
untitaker
Nov 2, 2015
Contributor
You can use assert_eq!(port.map(|x| x.to_string()), expected_port) here.
|
Closing, 1c9fb2f copied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rubys commentedOct 15, 2014
https://github.com/w3c/web-platform-tests/blob/master/url/urltestdata.txt