Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary bounds checking in a couple places. #394

Merged

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Sep 28, 2017

This change is Reviewable

@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 17, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

📌 Commit d3dfbf3 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

Testing commit d3dfbf3 with merge f721294...

bors-servo added a commit that referenced this pull request Oct 17, 2017
…=mbrubeck

Remove unnecessary bounds checking in a couple places.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/394)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2017

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing f721294 to master...

@bors-servo bors-servo merged commit d3dfbf3 into servo:master Oct 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin
Copy link
Member

SimonSapin commented Oct 17, 2017

Why?

unsafe is inherently dangerous, and the gains here seem like they’d be tiny if they exist at all. (The optimizer might be able to elide these checks anyway.) Is some benchmark improved by this change?

@SimonSapin
Copy link
Member

SimonSapin commented Oct 25, 2017

Reverting in #401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.