Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse opaque host parser for non-special schemes #403
Conversation
|
Please change the doc-comment of Next time we make breaking changes to this crate’s API, would it be useful to have Reviewed 5 of 5 files at r1. Comments from Reviewable |
|
The URL spec does list opaque hosts separately from regular hosts, but I don't know if this is useful reasons other than parsing the URL. Review status: 4 of 5 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
@bors-servo r+ Reviewed 1 of 1 files at r2. Comments from Reviewable |
|
|
Use opaque host parser for non-special schemes Addresses URL spec change: whatwg/url@3036255 For non-special schemes we use the opaque host parser - meaning the IDNA parser is not used, but instead we apply a UTF-8 percent encode using the simple encode set on the host input. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/403) <!-- Reviewable:end -->
|
|
valenting commentedOct 25, 2017
•
edited by larsbergstrom
Addresses URL spec change:
whatwg/url@3036255
For non-special schemes we use the opaque host parser - meaning the IDNA parser is not used, but instead we apply a UTF-8 percent encode using the simple encode set on the host input.
This change is