Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building wasm target #418

Closed
wants to merge 3 commits into from
Closed

Fix building wasm target #418

wants to merge 3 commits into from

Conversation

@tailhook
Copy link
Contributor

tailhook commented Dec 10, 2017 •
edited by larsbergstrom

Working on #417. This PR is just to make travis build tests.

This change is Reviewable
@tailhook tailhook force-pushed the tailhook:wasm branch from b2ca767 to c48ba83 Dec 10, 2017
tailhook added 2 commits Dec 10, 2017
@tailhook
Add wasm target to CI
8e86a50
@tailhook
Normalize end of line whitespace in src/lib.rs
Loading status checks…
c6e419f
@tailhook tailhook force-pushed the tailhook:wasm branch from c48ba83 to c6e419f Dec 10, 2017
@tailhook tailhook mentioned this pull request Dec 10, 2017
Closed
@tailhook
Fix building for `wasm32-unknown-unknown`
Loading status checks…
2683653
@tailhook tailhook changed the title [WIP] Fix building wasm target Fix building wasm target Dec 14, 2017
@tailhook
Copy link
Contributor Author

tailhook commented Dec 14, 2017

Similarly to windows wasm (non-enscripten) target now only works on utf-8 paths. Which is perfectly okay for URL's I think.
@SimonSapin
Copy link
Member

SimonSapin commented Dec 14, 2017

I’d prefer not to commit to any behavior of Path in wasm until this is more settled in Rust itself, and rather make path-related methods not exist on non-Unix non-Windows platforms.
@tailhook tailhook mentioned this pull request Dec 14, 2017
Merged
@tailhook
Copy link
Contributor Author

tailhook commented Dec 14, 2017

Okay, so there is #419 that does just that.
@tailhook tailhook closed this Dec 14, 2017
bors-servo added a commit that referenced this pull request Dec 15, 2017
@bors-servo
Auto merge of #419 - tailhook:remove_nonwasm_methods, r=SimonSapin
Loading status checks…
027450d 
Remove path related methods in wasm

Temporarily fixes #418 and #417

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/419)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tailhook @SimonSapin
You can’t perform that action at this time.