Add host_port and request_uir methods #421

mina86 · 2017-12-31T16:19:20Z

host_port and request_uri methods are useful when dealing with HTTP requests. host_port is what needs to be sent in Host header while request_uri is what needs to be sent in the request line.

This change is


        Add Url::request_uri method

When constructing HTTP requets path with the query string must be sent to the server. If customer of Url’s object needs to obtain that string they have to construct it by themselves and if query string is present in the URL allocation of a new String is necessary. Add a method which constructs the request UIR and returns reference to internal serialised storage avoiding the necessity to allocate a new String.


        Add Url::host_port_str method

HTTP Host header must include port number if that port does not correspond to the defalut port for given scheme¹. Introduce a method which returns such host-port string without the need to allocate a new String object. ¹ https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.23

SimonSapin · 2017-12-31T17:52:37Z

Aren’t these methods equivalent to &url[Position::BeforeHost..Position::AfterPort] and &url[Position::BeforePath..Position::AfterQuery] respectively? Position exists specifically to enable all kinds of slicing without adding lots of ad-hoc methods.

mina86 · 2017-12-31T18:53:01Z

Ha! Yes, I missed those in the documentation. host_port is not exactly equivalent to &url[Position::BeforeHost..Position::AfterPort] since it checks whether port is the default, but it’s close enough.

mina86 added 2 commits Dec 31, 2017

mina86 closed this Dec 31, 2017

servo / rust-url

Add host_port and request_uir methods #421

Add host_port and request_uir methods #421

mina86 commented Dec 31, 2017 •

edited by larsbergstrom

SimonSapin commented Dec 31, 2017

mina86 commented Dec 31, 2017 •

edited

servo / rust-url

Join GitHub today

Add host_port and request_uir methods #421

Add host_port and request_uir methods #421

Conversation

mina86 commented Dec 31, 2017 • edited by larsbergstrom

SimonSapin commented Dec 31, 2017

mina86 commented Dec 31, 2017 • edited

mina86 commented Dec 31, 2017 •

edited by larsbergstrom

mina86 commented Dec 31, 2017 •

edited