Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Host::serialize #426

Closed
wants to merge 1 commit into from
Closed

Introduce Host::serialize #426

wants to merge 1 commit into from

Conversation

@nox
Copy link
Member

nox commented Jan 17, 2018 •
edited by larsbergstrom

This change is Reviewable
@SimonSapin
Copy link
Member

SimonSapin commented Jan 18, 2018

As discussed on IRC the IPv6 case should use format!("[{}]", addr) and I’d prefer the method to be called serialize.
@nox nox force-pushed the to-cow branch from 8b1d1ff to c447b8b Jan 18, 2018
@nox nox changed the title Introduce Host::to_cow Introduce Host::serialize Jan 18, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Jan 18, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2018

📌 Commit c447b8b has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2018

⌛ Testing commit c447b8b with merge e87763f...
bors-servo added a commit that referenced this pull request Jan 18, 2018
@bors-servo
Auto merge of #426 - servo:to-cow, r=SimonSapin
Loading status checks…
e87763f 
Introduce Host::serialize

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/426)
<!-- Reviewable:end -->
@nox
Introduce Host::serialize
Loading status checks…
5ca0329
@nox nox force-pushed the to-cow branch from c447b8b to 5ca0329 Jan 18, 2018
@nox
Copy link
Member Author

nox commented Jan 18, 2018

My single use case can instead go through Display, which makes this method redundant, closing.
@nox nox closed this Jan 18, 2018
@nox nox deleted the to-cow branch Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @SimonSapin @bors-servo
You can’t perform that action at this time.