Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix encoding::EncodingOverride when not enabling query_encoding feature #431
+12
−11
Conversation
|
Cc @emilio @SimonSapin @Eijebong because we all have opinions about semver. |
The shape of the EncodingOverride type should not change whether the query_encoding feature is enabled or not.
|
This may be a good opportunity to define the missing methods that don't depend on the |
|
What’s the build issue? Note that the |
|
@SimonSapin Ooooooooh. Sorry for the brainfart. 'Tis no public, so there is no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedJan 24, 2018
•
edited by larsbergstrom
This is a breaking change, but at the same this fixes a bug that can cause build issues anyway, so I'm on the fence this time.
This change is