Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding::EncodingOverride when not enabling query_encoding feature #431

Closed
wants to merge 1 commit into from

Conversation

@nox
Copy link
Member

nox commented Jan 24, 2018

This is a breaking change, but at the same this fixes a bug that can cause build issues anyway, so I'm on the fence this time.


This change is Reviewable

@nox
Copy link
Member Author

nox commented Jan 24, 2018

Cc @emilio @SimonSapin @Eijebong because we all have opinions about semver.

The shape of the EncodingOverride type should not change whether the
query_encoding feature is enabled or not.
@nox nox force-pushed the encoding-override branch from 61a6b89 to c3a585c Jan 24, 2018
@nox
Copy link
Member Author

nox commented Jan 24, 2018

This may be a good opportunity to define the missing methods that don't depend on the encoding crate for when the feature is not enabled.

@SimonSapin
Copy link
Member

SimonSapin commented Jan 24, 2018

What’s the build issue?

Note that the encoding module is not public and its content not re-exported. Now that pub(crate) is a thing, we should use it for its contents to make that more clear.

@nox
Copy link
Member Author

nox commented Jan 24, 2018

@SimonSapin Ooooooooh. Sorry for the brainfart. 'Tis no public, so there is no problem.

@nox nox closed this Jan 24, 2018
@nox nox deleted the encoding-override branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.