Add data-url crate #432

SimonSapin · 2018-02-02T09:25:45Z

This is an implementation of https://fetch.spec.whatwg.org/#data-urls. It is independent of the url crate, but it seems within the scope of this repository and I didn’t feel like creating yet another repository :)

This change is


        cargo new


        First pass at implementing "the data: URL processor", untested for now.

https://fetch.spec.whatwg.org/#data-url-processor … except for MIME type parsing, which is left to the `mime` crate and may or may not match the specified parsing algorithm.


        Invalid MIME types default to "text/plain;charset=US-ASCII"


        Implicit "text/plain" when MIME type starts with ";"


        Don’t split at a comma within the URL fragment


        Separate base64 error from IO error


        Use a closure and a generic error type rather than io::Write


        Add a wrapper types for fragments


        Percent-encode the mime type like the URL parser would


        Percent-encode fragments


        Add a doctest


        Import test cases from Web Platform Tests

web-platform-tests/wpt@126495b /fetch/data-urls/resources/data-urls.json /fetch/data-urls/resources/base64.json /mimesniff/mime-types/resources/mime-types.json /mimesniff/mime-types/resources/generated-mime-types.json


        Run data URL tests from WPT


        Add base64 to the public API


        Add base64 decoding to Vec


        Move base64 to a separate module


        Run WPT tests for base64


        Add some detail to base64 errors


        Fix some base64 bugs


        Another base64 bug


        Run (very few of) the WPT MIME parsing tests


        Use serde to read JSON into custom types rather than serde_json::Value


        Switch to WHATWG’s MIME type parsing algorithm

… and a custom Rust type for MIME type records, because the mime crate does not have a constructor from components: hyperium/mime#78


        Add Mime::get_parameter


        Use `cargo test --all` on Travis


        Move into a subdirectory, to prepare for merge into the rust-url repo…

…sitory


        Merge branch 'master' of ../rust-data-url into data


        Travis: Only test url on 1.17 (data-url uses `pub(crate)`)


        Add data-url to the workspace


        Make url_serde use the local url crate when in the repo


        Attempt at fixing Travis config for 1.17


        Add metadata for the data-url crate

nox · 2018-02-02T09:36:40Z

@bors-servo r+

bors-servo · 2018-02-02T09:36:41Z

📌 Commit a6e63fe has been approved by nox

bors-servo · 2018-02-02T09:36:43Z

⌛ Testing commit a6e63fe with merge e447349...


        Auto merge of #432 - servo:data, r=nox

Add data-url crate This is an implementation of https://fetch.spec.whatwg.org/#data-urls. It is independent of the `url` crate, but it seems within the scope of this repository and I didn’t feel like creating yet another repository :)  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/432)

bors-servo · 2018-02-02T09:40:02Z

☀️ Test successful - status-travis
Approved by: nox
Pushing e447349 to master...

SimonSapin added 30 commits Jan 31, 2018

cargo new

4c61d25

First pass at implementing "the data: URL processor", untested for now.

ad7372a

https://fetch.spec.whatwg.org/#data-url-processor … except for MIME type parsing, which is left to the `mime` crate and may or may not match the specified parsing algorithm.

Invalid MIME types default to "text/plain;charset=US-ASCII"

c12c810

Implicit "text/plain" when MIME type starts with ";"

14c8206

Don’t split at a comma within the URL fragment

5551c48

Separate base64 error from IO error

dd3e072

Use a closure and a generic error type rather than io::Write

1cff0dd

Add a wrapper types for fragments

9d8acc3

Percent-encode the mime type like the URL parser would

1055810

Percent-encode fragments

6953b97

Add a doctest

5876b29

Import test cases from Web Platform Tests

7c4eeea

web-platform-tests/wpt@126495b /fetch/data-urls/resources/data-urls.json /fetch/data-urls/resources/base64.json /mimesniff/mime-types/resources/mime-types.json /mimesniff/mime-types/resources/generated-mime-types.json

Run data URL tests from WPT

e2b423a

Add base64 to the public API

cfe91f8

Add base64 decoding to Vec

0b58116

Move base64 to a separate module

63493ba

Run WPT tests for base64

fb3174b

Add some detail to base64 errors

f18ed94

Fix some base64 bugs

2456267

Another base64 bug

28c79fb

Run (very few of) the WPT MIME parsing tests

226e0a4

Use serde to read JSON into custom types rather than serde_json::Value

16e0e57

Switch to WHATWG’s MIME type parsing algorithm

72a19fa

… and a custom Rust type for MIME type records, because the mime crate does not have a constructor from components: hyperium/mime#78

Add Mime::get_parameter

d56fcdd

Use `cargo test --all` on Travis

a2851be

Move into a subdirectory, to prepare for merge into the rust-url repo…

cc670f6

…sitory

Merge branch 'master' of ../rust-data-url into data

e76e98c

Travis: Only test url on 1.17 (data-url uses `pub(crate)`)

be56f24

Add data-url to the workspace

Loading status checks…

a715ed9

Make url_serde use the local url crate when in the repo

458f67f

SimonSapin added 2 commits Feb 2, 2018

Attempt at fixing Travis config for 1.17

56446b4

Add metadata for the data-url crate

Loading status checks…

a6e63fe

SimonSapin deleted the data branch Feb 2, 2018

servo / rust-url

Add data-url crate #432

Add data-url crate #432

SimonSapin commented Feb 2, 2018 •

edited by larsbergstrom

nox commented Feb 2, 2018

bors-servo commented Feb 2, 2018

bors-servo commented Feb 2, 2018

bors-servo commented Feb 2, 2018

servo / rust-url

Join GitHub today

Add data-url crate #432

Add data-url crate #432

Conversation

SimonSapin commented Feb 2, 2018 • edited by larsbergstrom

nox commented Feb 2, 2018

bors-servo commented Feb 2, 2018

bors-servo commented Feb 2, 2018

bors-servo commented Feb 2, 2018

SimonSapin commented Feb 2, 2018 •

edited by larsbergstrom