Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to rustc_test 0.3, unbreak tests on nightly-2018-02-25 #439
+5
−5
Conversation
Version 0.2 of the crates.io package `rustc_test` uses `test` as its rustc crate name, shadowing the `test` crate from the standard library. This made up subject to breaking changes to its private APIs: https://travis-ci.org/SimonSapin/run-nightly/builds/345808272#L549
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 25, 2018
Update to rustc_test 0.3, unbreak tests on nightly-2018-02-25 Version 0.2 of the crates.io package `rustc_test` uses `test` as its rustc crate name, shadowing the `test` crate from the standard library. This made up subject to breaking changes to its private APIs: https://travis-ci.org/SimonSapin/run-nightly/builds/345808272#L549 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/439) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedFeb 25, 2018
•
edited by larsbergstrom
Version 0.2 of the crates.io package
rustc_testusestestas its rustc crate name, shadowing thetestcrate from the standard library. This made up subject to breaking changes to its private APIs:https://travis-ci.org/SimonSapin/run-nightly/builds/345808272#L549
This change is