Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Cargo feature `query_encoding_2` to use `encoding_rs` crate #445
Conversation
hsivonen
commented
Apr 5, 2018
|
See my old PR on the same topic for a more copy-avoiding implementation of |
|
Thanks @hsivonen. I just copied your old Cow code, hope you don't mind. |
hsivonen
commented
Apr 5, 2018
|
I don't mind. I pointed to it so that you'd copy it. Thanks. |
|
Closing temporarily. I want to fix I don't think I'll go the trait approach, since IMO that seems like overkill when AFAIK there are no plans to make a third encoding crate. And if there were another encoding implementation, there's no guarantee it would fit nicely into the existing encoding API. cc @SimonSapin |
talklittle commentedApr 5, 2018
•
edited by larsbergstrom
Fixes #444
This change is