Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a lifetime bug uncovered by NLL, thanks @lqd #457

Merged
merged 1 commit into from Aug 23, 2018
Merged

Fix a lifetime bug uncovered by NLL, thanks @lqd #457

merged 1 commit into from Aug 23, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 23, 2018 •
edited by larsbergstrom

Same as #454, but backported to rust-url 1.6.0 (as 1.6.1) to avoid dealing with unrelated rust-url changes in servo/servo#21356.

This change is Reviewable
@SimonSapin
Fix a lifetime bug uncovered by NLL, thanks @lqd
Loading status checks…
5852553
@SimonSapin SimonSapin merged commit 5852553 into master Aug 23, 2018
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
@SimonSapin SimonSapin deleted the nll branch Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@SimonSapin
You can’t perform that action at this time.