Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test case for ambiguous ipv6 #466
Conversation
|
The parsing algorithm that we implement only looks for an IPv6 address if it’s enclosed in |
|
Looking more closely, I think this is not related to IPv6 at all. The The parser is very flexible and accepts unknown protocols. For example, This parser is designed to parse strings that are already delimited by some other markers, for example the value of the |
|
Also, this test shouldn't be in urltestdata.json. |
|
The original alacritty issue was closed, I don't think we should land this anyway, closing. |
jedahan commentedOct 30, 2018
•
edited by larsbergstrom
I don't think this should be merged, because CI will fail, but it would be nice to start the conversation if this truly should be an error. Motivation is reducing false positives in alacritty/alacritty#1727 .
If we determine it should be an error, I'd like to tackle fixing it.
This change is