Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redox support #477

Merged
merged 1 commit into from Jan 14, 2019
Merged

Redox support #477

merged 1 commit into from Jan 14, 2019
+5 −1

Conversation

@jackpot51
Copy link
Contributor

jackpot51 commented Jan 14, 2019 •
edited by larsbergstrom

Redox uses file: at the beginning of any file paths. Therefore, a path like file:///home/user/some%20file.txt needs to turn into file:/home/user/some file.txt

This change is Reviewable
@SimonSapin
Copy link
Member

SimonSapin commented Jan 14, 2019

The initial value of bytes is the only difference with the Unix variant of this function, right? I’d prefer we keep a single function and use something like let mut bytes = if cfg!(target_os = "redox") { b"file:".to_vec() } else { Vec::new() };, to reduce code duplication.

Does the path_to_file_url_segments function need any corresponding change?
@jackpot51
Copy link
Contributor Author

jackpot51 commented Jan 14, 2019

Good point, I can do that
@jackpot51
Copy link
Contributor Author

jackpot51 commented Jan 14, 2019

I will check path_to_file_url_segments
@jackpot51
Redox patches
Verified
This commit was signed with a verified signature.
jackpot51 Jeremy Soller
GPG key ID: E988B49EE78A7FB1 Learn about signing commits
Loading status checks…
01404b7
@jackpot51 jackpot51 force-pushed the redox-os:redox branch from 405c5f9 to 01404b7 Jan 14, 2019
@jackpot51
Copy link
Contributor Author

jackpot51 commented Jan 14, 2019 •
edited

I cleaned up the patch. It is the best I can do so far. There is not much I can do with path_to_file_url_segments until this issue is solved: rust-lang/rust#52331

I would recommend that this PR is merged and I can create an issue to update the other function when possible.
@jackpot51 jackpot51 mentioned this pull request Jan 14, 2019
Open
@SimonSapin
Copy link
Member

SimonSapin commented Jan 14, 2019

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2019

📌 Commit 01404b7 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2019

⌛ Testing commit 01404b7 with merge a1d8c88...
bors-servo added a commit that referenced this pull request Jan 14, 2019
@bors-servo
Auto merge of #477 - redox-os:redox, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a1d8c88 
Redox support

Redox uses `file:` at the beginning of any file paths. Therefore, a path like `file:///home/user/some%20file.txt` needs to turn into `file:/home/user/some file.txt`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/477)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2019

☀️ Test successful - checks-travis
Approved by: SimonSapin
Pushing a1d8c88 to master...
@bors-servo bors-servo merged commit 01404b7 into servo:master Jan 14, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jackpot51 @SimonSapin @bors-servo
You can’t perform that action at this time.