Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include url::Position in top-level docs #495

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@djmitche
Copy link
Contributor

djmitche commented Apr 22, 2019

This helps discoverability of this pretty cool functionality.

Follow-up from #492.


This change is Reviewable

This helps discoverability of this pretty cool functionality.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 24, 2019

Looks good, thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2019

📌 Commit 8db631c has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2019

Testing commit 8db631c with merge 89dc0b7...

bors-servo added a commit that referenced this pull request Apr 24, 2019
Include url::Position in top-level docs

This helps discoverability of this pretty cool functionality.

Follow-up from #492.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/495)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2019

☀️ Test successful - checks-travis
Approved by: SimonSapin
Pushing 89dc0b7 to master...

@bors-servo bors-servo merged commit 8db631c into servo:master Apr 24, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.