Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upuse enum ParseError for errors instead of strings #5
+107
−53
Conversation
|
Thanks for contributing! Please add |
|
Ah sure, I didn't realize that was additional tests beyond
|
SimonSapin
added a commit
that referenced
this pull request
Aug 1, 2014
use enum ParseError for errors instead of strings
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
seanmonstar commentedJul 31, 2014
Strings make things harder. When trying to decide if my error_handler should eat the error or not, the compiler won't notice if I typo an error message. And if the message changes, the compiler won't warn me about a non-existent enum variant.
With an enum, I can match for certains errors. I made the Show implementation mirror the text of the errors from before, in case they were used to show in a Browser Console or something. This also allows for the messages to be adjusted slightly, while leaving the variant alone.