Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated log_syntax_violation function for 2.0 #509

Closed
wants to merge 1 commit into from
Closed

Remove the deprecated log_syntax_violation function for 2.0 #509

wants to merge 1 commit into from
+0 −33

Conversation

@est31
Copy link
Contributor

est31 commented Jul 13, 2019 •
edited

I've also removed the OldFn variant as that function was the only place that variant was constructed. Does it make sense to rename the NewFn variant to something else? Idk.

This change is Reviewable
@est31
Remove the deprecated log_syntax_violation function for 2.0
Loading status checks…
85bfa53
@est31
Copy link
Contributor Author

est31 commented Jul 13, 2019

Hmm it seems that the ViolationFn enum was introduced in #433 , before there was an Option. Should I bring back the old state of using an Option? Should I rename the ViolationFn variants instead?
@est31
Copy link
Contributor Author

est31 commented Jul 13, 2019

Wrong branch here, too :)
@est31 est31 closed this Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@est31
You can’t perform that action at this time.