Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix warnings and increase MSRV for 2.0 #510
Merged
Conversation
It is deprecated since 1.26.0 if the inherent methods, that are stable since 1.23.0, want to be relied on.
This requires at least rustc 1.24.0 as only then the function became stably const-fn.
The 1.24.0 release has been over a year ago and is needed by the prior commits.
| @@ -11,8 +11,7 @@ jobs: | |||
|
|
|||
| - cargo update -p unicode-normalization --precise 0.1.5 | |||
|
|
|||
| # data-url uses pub(crate) which is unstable in 1.17 | |||
| script: cargo test --all-features -p url -p idna -p percent-encoding -p url_serde | |||
| script: cargo test --all-features -p url -p idna -p percent-encoding -p url_serde -p data-url | |||
This comment has been minimized.
This comment has been minimized.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
est31 commentedJul 13, 2019
•
edited by larsbergstrom
This includes some warning fixes as well as a MSRV increase from 1.17.0 to 1.24.0 (which is the oldest release the replacements for the deprecated functionalities are available). The first commit should be least controversial as it doesn't require any MSRV increase. Please say whether MSRV increases are a problem, if they are I can put the first commit into a separate PR.
Fixes #455
This change is