Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove the deprecated log_syntax_violation function for 2.0 #511
Conversation
|
If you replaced the enum with an Option, you'd still need to wrap in a new-type (generic over the lifetime) to implement the same specific methods for the type, right? Looks good to me, the way you have it. |
|
Merged in the 2.0 branch, with an Thanks! |
|
…or move those methods to |
|
Merge commit was: 90e65b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
est31 commentedJul 13, 2019
•
edited by larsbergstrom
I've also removed the
OldFnvariant as that function was the only place that variant was constructed.Does that make sense or should I replace the entire enum with
Option's everywhere like it was before #433?This change is