Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to serde 1.0 #512

Merged
merged 1 commit into from Jul 14, 2019
Merged

Update to serde 1.0 #512

merged 1 commit into from Jul 14, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jul 14, 2019

This change is Reviewable

@SimonSapin
Copy link
Member Author

SimonSapin commented Jul 14, 2019

@bors-servo r+

Thanks @est31!

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2019

📌 Commit d6c3bcd has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2019

Testing commit d6c3bcd with merge ca5f6c8...

bors-servo added a commit that referenced this pull request Jul 14, 2019
Update to serde 1.0

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/512)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2019

☀️ Test successful - checks-travis
Approved by: SimonSapin
Pushing ca5f6c8 to 2.0...

@bors-servo bors-servo merged commit d6c3bcd into servo:2.0 Jul 14, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@est31
Copy link
Contributor

est31 commented Jul 14, 2019

@SimonSapin oh you prefer this implementation? Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.