Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange the closure taken by `with_default_port` to return Option instead #516
+14
−17
Conversation
of Result. `Result` seems like overkill for the closure, especially now that the `?` operator has been stabilized for `Option`.
|
|
|
Looks like that function was removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tmccombs commentedJul 15, 2019
•
edited by larsbergstrom
of Result.
Resultseems like overkill for the closure, especially now that the?operator has been stabilized forOption.Related to #299
This change is