Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yay! New language/Cargo features! #52

Merged
merged 7 commits into from Nov 21, 2014
Merged

Yay! New language/Cargo features! #52

merged 7 commits into from Nov 21, 2014

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 20, 2014

Is anyone interested in reviewing this? (Recommended by commit rather than by file.) If not, I’ll just merge it.

@chris-morgan

This comment has been minimized.

Copy link
Contributor

chris-morgan commented on src/parser.rs in ad2d4c8 Nov 21, 2014

Why “can not” rather than “cannot” for all of these? The two are distinctly different in meaning and the latter is the one intended (to say nothing of the variant names).

This comment has been minimized.

Copy link
Member Author

SimonSapin replied Nov 21, 2014

They are? English is not my first language, please explain.

This comment has been minimized.

Copy link
Contributor

mbrubeck replied Nov 21, 2014

For what it's worth, I am a native speaker and had never heard this before. The dictionaries and usage guides I checked claim they are interchangeable. From the Oxford English Dictionary:

cannot, v.

the ordinary modern way of writing can not

From Merriam-Webster:

Definition of CANNOT

can not

[Edit: That said, cannot is more common, and may be less ambiguous if other people read can not differently, as @chris-morgan does.]

[Edit 2: Oh, I see the ambiguity. "can not set" can be read either "(can not) set" as intended, or "can (not set)" which has a very different meaning indeed.]

This comment has been minimized.

Copy link
Contributor

chris-morgan replied Nov 21, 2014

Yeah, the ambiguity is the matter; “can not set” is, devoid of context, more likely to mean “it is possible not to set” (given the context, the ambiguity can be resolved) while “cannot set” means “it is not possible to set”.

Ain’t English marvellous?

@chris-morgan

This comment has been minimized.

Copy link
Contributor

chris-morgan commented on e6866f2 Nov 21, 2014

Yeah, I think it’s reasonable to consider isindex obsolete!

This comment has been minimized.

Copy link
Member Author

SimonSapin replied Nov 21, 2014

Maybe some day someone will complain about some random website that looks broken in Servo because of isindex, and maybe we’ll bring it back. Until then…

This comment has been minimized.

Copy link
Contributor

Ms2ger replied Nov 21, 2014

I'll ask for it now.

This comment has been minimized.

Copy link
Member Author

SimonSapin replied Nov 21, 2014

Eh. How about I bring it back as soon as Servo would use it?

@mbrubeck

This comment has been minimized.

Copy link
Contributor

mbrubeck commented on src/encoding.rs in 9ae1fd2 Nov 21, 2014

Some rustdoc comments would be welcome here.

This comment has been minimized.

Copy link
Member Author

SimonSapin replied Nov 21, 2014

I’ll add comments, but this type is private and should not show up in rustdoc.

@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 21, 2014

r=mbrubeck, modulo the comments above

@SimonSapin SimonSapin merged commit 9ae1fd2 into master Nov 21, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
SimonSapin added a commit that referenced this pull request Nov 21, 2014
@SimonSapin SimonSapin deleted the lostastuff branch Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.