Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an upgrade guide for v2.0. #536

Merged
merged 2 commits into from Sep 2, 2019
Merged

Add an upgrade guide for v2.0. #536

merged 2 commits into from Sep 2, 2019

Conversation

@benesch
Copy link
Contributor

benesch commented Aug 1, 2019

Extracted from #534, with review feedback addressed. This variant omits the changelogs in an effort to introduce less of a maintenance burden.

Fix #532.


This change is Reviewable

UPGRADING.md Outdated Show resolved Hide resolved
@benesch
Copy link
Contributor Author

benesch commented Sep 1, 2019

@SimonSapin, I believe this is ready to be merged.

@benesch benesch force-pushed the benesch:upgrade-20 branch from cc74c93 to 4f805dd Sep 1, 2019
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
Fix #532.

Co-Authored-By: Jeremy Lempereur <jeremy.lempereur@gmail.com>
@benesch benesch force-pushed the benesch:upgrade-20 branch from 4f805dd to 6c24e0a Sep 2, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Sep 2, 2019

Looks good, thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2019

📌 Commit 0311660 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2019

Testing commit 0311660 with merge 7d2c9d6...

bors-servo added a commit that referenced this pull request Sep 2, 2019
Add an upgrade guide for v2.0.

Extracted from #534, with review feedback addressed. This variant omits the changelogs in an effort to introduce less of a maintenance burden.

Fix #532.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/536)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 2, 2019

☀️ Test successful - checks-travis
Approved by: SimonSapin
Pushing 7d2c9d6 to master...

@bors-servo bors-servo merged commit 0311660 into servo:master Sep 2, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.