Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rust master #66

Merged
merged 1 commit into from Dec 25, 2014
Merged

Update to rust master #66

merged 1 commit into from Dec 25, 2014

Conversation

@alexcrichton
Copy link
Contributor

alexcrichton commented Dec 23, 2014

No description provided.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 24, 2014

Is it expected that everything implement Encodable and Decodable? This was added on Url because someone asked for it, but now that serialize is out of the rustc distribution I’d rather not bother and make it a dev-dependency.

What do you think? Would this be a regression, or does nobody care?

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 24, 2014

If it was requested for Servo, feel free to get rid of it.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 24, 2014

After looking it up: it wasn't for Servo, it was for Iron in #27. @reem, what de you think?

@alexcrichton
Copy link
Contributor Author

alexcrichton commented Dec 24, 2014

@SimonSapin perhaps an optional dependency?

@reem
Copy link

reem commented Dec 25, 2014

@SimonSapin I requested it because someone wanted iron::Url to implement those traits. Considering they are deprecated I don't mind if those implementations don't go away.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 25, 2014

Considering they are deprecated I don't mind if those implementations don't go away.

Did you mean the double negation?

SimonSapin added a commit that referenced this pull request Dec 25, 2014
Update to rust master
@SimonSapin SimonSapin merged commit 39ae216 into servo:master Dec 25, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@SimonSapin
Copy link
Member

SimonSapin commented Dec 25, 2014

Just taking this as-is was easier than doing the dev-dependency dance. Published v0.2.8.

@reem
Copy link

reem commented Dec 26, 2014

@SimonSapin I didn't. I actually now think that we should be dropping dependencies on rustc-serialize as much as we can, since it's yet another dependency that will need maintenance and updates.

@SimonSapin
Copy link
Member

SimonSapin commented Dec 26, 2014

Some rust-url tests still need it to parse a JSON file. I wouldn’t mind switching to another crate that only does JSON, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.