Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for upstream changes #70
Merged
Conversation
src/format.rs
Outdated
| try!(formatter.write(b"?")); | ||
| try!(formatter.write(query.as_bytes())); | ||
| try!(formatter.write_str("?")); | ||
| try!(formatter.write_str(&**query)); |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Jan 3, 2015
Member
Is &**query preferable to query.as_slice()? (Same for &*self.url.scheme v.s. self.url.scheme.as_slice())
This comment has been minimized.
This comment has been minimized.
sfackler
Jan 3, 2015
Author
Contributor
Not sure. It's what I've been using for my own stuff. I don't feel too strongly either way, though.
This comment has been minimized.
This comment has been minimized.
|
Updated |
|
Thanks! |
SimonSapin
merged commit 886faa5
into
servo:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sfackler commentedJan 3, 2015
No description provided.