Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #78

Merged
merged 1 commit into from Feb 4, 2015
Merged

Update #78

merged 1 commit into from Feb 4, 2015

Conversation

@retep998
Copy link
Contributor

retep998 commented Feb 3, 2015

No description provided.

Update
Signed-off-by: Peter Atashian <retep998@gmail.com>
@Hoverbear
Copy link
Member

Hoverbear commented Feb 3, 2015

This is for the iter() changes regarding moves and the FromStr changes.

@badboy
Copy link

badboy commented Feb 4, 2015

About the iter() changes, today I committed this on my own fork to make it work again: https://github.com/badboy/rust-url/commit/12d7e614babf42b151375e6eba422c605a2c76f7

Hoverbear added a commit that referenced this pull request Feb 4, 2015
Fix `iter()` and `FromStr` changes.
@Hoverbear Hoverbear merged commit 5c2441d into servo:master Feb 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@SimonSapin
Copy link
Member

SimonSapin commented Feb 4, 2015

@Hoverbear Thanks for volunteering to co-maintain! You should have access to publish on crates.io now. To do so:

  • Run git pull if a PR was merged with the green button.
  • Edit Cargo.toml to increment the version number. (Micro component for language upgrade)
  • Run cargo publish. If it fails, fix things until it succeeds.
  • Run git commit -a -m v0.2.17 (with the version number copy/pasted form the output of cargo publish)
  • Run git tag v0.2.17 (with the version number copy/pasted form the output of cargo publish)
  • Run git push && git push --tags
@Hoverbear
Copy link
Member

Hoverbear commented Feb 4, 2015

@SimonSapin Thanks. When is it appropriate to publish a new crate version?

@SimonSapin
Copy link
Member

SimonSapin commented Feb 4, 2015

@Hoverbear Whenever there is a change since the last publication that might be useful to someone, which is definitely the case for fixes like this for breaking language changes. If in doubt, publish. Publishing is cheap. I would have Travis-CI do it on every push to master that passes tests, except that deciding which component of the version number to increment is hard to automate.

(I also gave access to @seanmonstar who published for this PR (thanks!) so you don’t need to do it right now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.