Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "upstream rust: std::path moved to std::old_path" #80

Merged
merged 1 commit into from Feb 7, 2015
Merged

Revert "upstream rust: std::path moved to std::old_path" #80

merged 1 commit into from Feb 7, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Feb 7, 2015

Reverts #79
@SimonSapin
Revert "upstream rust: std::path moved to std::old_path"
Loading status checks…
d151a56
SimonSapin added a commit that referenced this pull request Feb 7, 2015
@SimonSapin
Merge pull request #80 from servo/revert-79-rust_path
Loading status checks…
d2afb8b 
Revert "upstream rust: std::path moved to std::old_path"
@SimonSapin SimonSapin merged commit d2afb8b into master Feb 7, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
@SimonSapin SimonSapin deleted the revert-79-rust_path branch Feb 7, 2015
@Hoverbear
Copy link
Member

Hoverbear commented Feb 7, 2015

@SimonSapin Why did you revert this?
@SimonSapin
Copy link
Member Author

SimonSapin commented Feb 7, 2015

It and b8c456e (which I had already published but forgot to push) were redundant, and I prefer the latter which uses use std::old_path as path; so that the rest of the code doesn’t need to be changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@SimonSapin @Hoverbear
You can’t perform that action at this time.