Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump rustc-serialize and use std::path #84
Conversation
|
Er sorry, forgot to fill out some other portions, adding tests and such now. |
5fa4222
to
e36390e
This commit bumps the dependency on rustc-serialize to 0.3 and allows `Url::from_file_path` to work with `std::path::Path` as well (transitively working for `PathBuf` too).
|
Ok! Filled out tests and verified that it's working on both unix and windows |
|
Is it still useful to have both It's unfortunate that we now can't manipulate/test paths for platforms other than the one we build for (compared to using e.g. |
Bump rustc-serialize and use std::path
|
Currently yes I believe that the distinction is available. Very little normalization happens by default so For example: http://is.gd/l1SS8I |
|
Right, this is what I meant. But I don’t know if we can rely on things like |
|
Ah yes that I would not rely on (I doubt |
|
Ok, so we’ll keep the separate Thanks for the PR! |
alexcrichton commentedFeb 25, 2015
This commit bumps the dependency on rustc-serialize to 0.3 and allows
Url::from_file_pathto work withstd::path::Pathas well (transitivelyworking for
PathBuftoo).