Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upurlutils.rs - an empty password should be saved as None, not empty string #93
Conversation
SimonSapin
added a commit
that referenced
this pull request
Apr 10, 2015
urlutils.rs - an empty password should be saved as None, not empty string
|
This matches the spec at https://url.spec.whatwg.org/#set-the-password . Thanks! Let me know if you need this on crates.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
valenting commentedApr 9, 2015
Right now, if I set a username and password, then I clear them, the url serialization would be http://:@example.com
Easily solved just by setting the password to None when the input is empty string.