Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing 'use' for percent_decode #96

Merged
merged 1 commit into from Apr 23, 2015
Merged

add missing 'use' for percent_decode #96

merged 1 commit into from Apr 23, 2015

Conversation

@fuchsnj
Copy link
Contributor

fuchsnj commented Apr 23, 2015

closes #95
@fuchsnj
add missing 'use' for percent_decode
Loading status checks…
d03b7f3
@SimonSapin
Copy link
Member

SimonSapin commented Apr 23, 2015

Ugh, another case of #89 (comment) :(

Thanks for the fix!
SimonSapin added a commit that referenced this pull request Apr 23, 2015
@SimonSapin
Merge pull request #96 from fuchsnj/master
Loading status checks…
50e3ed7 
add missing 'use' for percent_decode
@SimonSapin SimonSapin merged commit 50e3ed7 into servo:master Apr 23, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@SimonSapin
Copy link
Member

SimonSapin commented Apr 23, 2015

This produces a warning: unused import on non-windows, so I moved the import into the function that uses it: 5b79927.
@SimonSapin SimonSapin mentioned this pull request May 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

fails to compile with rust nightly on Windows (4/22)
2 participants
@fuchsnj @SimonSapin
You can’t perform that action at this time.