Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Daydream VR transition #74

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@jdm
Copy link
Member

commented May 3, 2019

Previously when Daydream paused the activity, Servo would stop the presentation which would end up calling back into the GVR service and we would set mPresenting to false. This means that when Daydream resumed, the GVR service would check mPresenting and decide that it did not need to do anything. By tracking the paused status separately, we can act accordingly when Daydream resumes our activity.

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

📌 Commit ca45fff has been approved by Manishearth

bors-servo added a commit that referenced this pull request May 3, 2019

Auto merge of #74 - servo:daydream, r=Manishearth
Support Daydream VR transition

Previously when Daydream paused the activity, Servo would stop the presentation which would end up calling back into the GVR service and we would set mPresenting to false. This means that when Daydream resumed, the GVR service would check mPresenting and decide that it did not need to do anything. By tracking the paused status separately, we can act accordingly when Daydream resumes our activity.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

⌛️ Testing commit ca45fff with merge 43d6432...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing 43d6432 to master...

@bors-servo bors-servo merged commit ca45fff into master May 3, 2019

3 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.